commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <>
Subject [jira] [Work logged] (IMAGING-165) TiffReader.Collector adds values to a field List<TiffField> but never uses it
Date Wed, 16 Oct 2019 07:44:00 GMT


ASF GitHub Bot logged work on IMAGING-165:

                Author: ASF GitHub Bot
            Created on: 16/Oct/19 07:43
            Start Date: 16/Oct/19 07:43
    Worklog Time Spent: 10m 
      Work Description: kinow commented on pull request #12: IMAGING-165
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

            Worklog Id:     (was: 329019)
    Remaining Estimate: 0h
            Time Spent: 10m

> TiffReader.Collector adds values to a field List<TiffField> but never uses it
> -----------------------------------------------------------------------------
>                 Key: IMAGING-165
>                 URL:
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Format: TIFF
>            Reporter: Michael GroƟ
>            Priority: Major
>             Fix For: Discussion
>          Time Spent: 10m
>  Remaining Estimate: 0h
> org.apache.commons.imaging.formats.tiff.TiffReader.Collector adds values to a field List<TiffField>
but never uses it. This could be the cause of some problems reported elsewhere.
> TiffReader contains an embedded class named Collector. This class has a private field
> {noformat}
> private static class Collector implements Listener {
>         private final List<TiffField> fields = new ArrayList<TiffField>();
> {noformat}
> There are values added in a method named
> {noformat}
> public boolean addField(final TiffField field) {
>      fields.add(field);
>      return true;
> }
> {noformat}
> This method is the only which uses this field so these values are never used. Is there
a getter missing? Or was it intended to use these values in class TiffContents like "tiffHeader"
and "directories"?
> {noformat}
> public TiffContents getContents() {
>     return new TiffContents(tiffHeader, directories);
> }
> {noformat}
> At least the method "addField" seems unused but necessary to implement the "Listener"

This message was sent by Atlassian Jira

View raw message