commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (LANG-1177) Improve indexOf performance when called multiple times
Date Sat, 19 Oct 2019 12:02:00 GMT

     [ https://issues.apache.org/jira/browse/LANG-1177?focusedWorklogId=330927&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330927
]

ASF GitHub Bot logged work on LANG-1177:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Oct/19 12:01
            Start Date: 19/Oct/19 12:01
    Worklog Time Spent: 10m 
      Work Description: lielfr commented on pull request #471: [LANG-1177] Added indexesOf
methods and simplified removeAllOccurences
URL: https://github.com/apache/commons-lang/pull/471#discussion_r336734563
 
 

 ##########
 File path: src/main/java/org/apache/commons/lang3/ArrayUtils.java
 ##########
 @@ -3254,6 +3254,57 @@ public static int indexOf(final Object[] array, final Object objectToFind,
int s
         return INDEX_NOT_FOUND;
     }
 
+    /**
+     * <p>Finds the indices of the given object in the array.
+     *
+     * <p>This method returns an empty BitSet for a {@code null} input array.
+     *
+     * @param array  the array to search through for the object, may be {@code null}
+     * @param objectToFind  the object to find, may be {@code null}
+     * @return a BitSet of all the indices of the object within the array,
+     *  an empty BitSet if not found or {@code null} array input
 
 Review comment:
   Done
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 330927)
    Time Spent: 1h  (was: 50m)

> Improve indexOf performance when called multiple times
> ------------------------------------------------------
>
>                 Key: LANG-1177
>                 URL: https://issues.apache.org/jira/browse/LANG-1177
>             Project: Commons Lang
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> The indexOf methods search for a single entry in an array.
> This works fine when only the first matching entry is needed, however it is not so efficient
when all matches are needed (because of the setup/teardown overheads).
> It might be useful to introduce an indexesOf method that returns a BitSet containing
all the matches.
> This can then be used in the removeAllOccurrences methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message