commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (CSV-247) A single empty header is allowed when not allowing empty column headers.
Date Mon, 07 Oct 2019 16:59:00 GMT

     [ https://issues.apache.org/jira/browse/CSV-247?focusedWorklogId=324495&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324495
]

ASF GitHub Bot logged work on CSV-247:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Oct/19 16:58
            Start Date: 07/Oct/19 16:58
    Worklog Time Spent: 10m 
      Work Description: coveralls commented on issue #47: CSV-247: CSVParser to check an empty
header before checking duplicates.
URL: https://github.com/apache/commons-csv/pull/47#issuecomment-508031331
 
 
   
   [![Coverage Status](https://coveralls.io/builds/26160404/badge)](https://coveralls.io/builds/26160404)
   
   Coverage decreased (-0.007%) to 92.921% when pulling **c4633eada5bc97cd8e4245954891738364428da3
on aherbert:fix-CSV-247** into **dcc44cdcd1419c65cc0b51a7368f3a63a06e9872 on apache:master**.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 324495)
    Time Spent: 50m  (was: 40m)

> A single empty header is allowed when not allowing empty column headers.
> ------------------------------------------------------------------------
>
>                 Key: CSV-247
>                 URL: https://issues.apache.org/jira/browse/CSV-247
>             Project: Commons CSV
>          Issue Type: Bug
>    Affects Versions: 1.7
>            Reporter: Alex Herbert
>            Priority: Minor
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> If the settings are not allowing empty columns headers you can currently use a single
empty header. This is because column headers are only checked for empty when they are duplicates.
So it is the second empty header (the first duplicate) that raises an error. This test should
pass but does not:
> {code:java}
> @Test(expected = IllegalArgumentException.class)
> public void testHeadersMissingOneColumnException() throws Exception {
>     final Reader in = new StringReader("a,,c,d\n1,2,3,4\nx,y,z,zz");    CSVFormat.DEFAULT.withHeader().parse(in).iterator();

> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message