commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles Sadowski (Jira)" <j...@apache.org>
Subject [jira] [Commented] (COLLECTIONS-728) BloomFilter contribution
Date Fri, 25 Oct 2019 19:21:00 GMT

    [ https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960002#comment-16960002
] 

Gilles Sadowski commented on COLLECTIONS-728:
---------------------------------------------

bq. there is nothing in it that allows you to add another filter.

The file is not assumed to be complete; the point was to show that all the functionality,
except state and states-specific implementations, could be in one (Java 8) interface.

bq. I think this can be part of the interface but is not required. It could be moved to a
separate class as it just acts as a calculator.

Nested class {{Shape}} provides the "boiler-plate" code needed by all implementations.

{quote}
# Is a BloomFilter defined by its size and set bits?
{quote}

Probably, but a user should not care much, as long as the API provides instance, and they
are used consistently (e.g. merging should only be done among instances produced from the
same "builder").

{quote}
# ...
# Can we match BloomFilters of different lengths?
{quote}

I'd say "no" (?).  At least, it seems like looking for trouble.

bq. size and access to set bits should be available within the interface.

Maybe, but I wouldn't make it part of the API before a use-case shows that it's absolutely
necessary.

bq. pad the smaller filter with nothing

?

bq. core functionality

IIUC, this should only refer to the methods in the {{BloomFilter}} interface.

The {{Skeleton}} (a.k.a. {{ProtoBloomFilter}} in Claude's PR) contains the configuration information
to be used by implementations of the interface in order to create compatible instances (that
can be "merged" and "matched").

> BloomFilter contribution
> ------------------------
>
>                 Key: COLLECTIONS-728
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-728
>             Project: Commons Collections
>          Issue Type: Task
>            Reporter: Claude Warren
>            Priority: Minor
>         Attachments: BF_Func.md, BloomFilter.java, BloomFilterI2.java, Usage.md
>
>
> Contribution of BloomFilter library comprising base implementation and gated collections.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message