commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-collections] garydgregory commented on a change in pull request #102: Add test cases in UnmodifiableMultiValuedMapTest
Date Fri, 01 Nov 2019 15:27:23 GMT
garydgregory commented on a change in pull request #102: Add test cases in UnmodifiableMultiValuedMapTest
URL: https://github.com/apache/commons-collections/pull/102#discussion_r341622969
 
 

 ##########
 File path: src/test/java/org/apache/commons/collections4/multimap/UnmodifiableMultiValuedMapTest.java
 ##########
 @@ -100,6 +96,68 @@ public void testAddException() {
         }
     }
 
+    public void testRemoveException() {
+        final MultiValuedMap<K, V> map = makeFullMap();
+        try {
+            map.remove((K) "one");
+            fail();
+        } catch (final UnsupportedOperationException e) {
+        }
 
 Review comment:
   Comment empty blocks so we know why we are ignoring exceptions. It helps others to understand
the code more quicly IMO.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message