commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-collections] garydgregory commented on a change in pull request #103: Add junit for getWithNull and subList in the LazyListTest.
Date Fri, 01 Nov 2019 15:30:03 GMT
garydgregory commented on a change in pull request #103: Add junit for getWithNull and subList
in the LazyListTest.
URL: https://github.com/apache/commons-collections/pull/103#discussion_r341624202
 
 

 ##########
 File path: src/test/java/org/apache/commons/collections4/list/FixedSizeListTest.java
 ##########
 @@ -83,4 +83,66 @@ public void testListAllowsMutationOfUnderlyingCollection() {
         Assert.assertEquals("Modifying an the underlying list is allowed",
                 sizeBefore + 1, fixedSizeList.size());
     }
+
+    //-----------------------------------------------------------------------
 
 Review comment:
   Let's not add these kinds of `//---...` lines as they appear, to me, as just noise.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message