commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-imaging] kinow commented on a change in pull request #55: Add support to read multiple images from GIF
Date Fri, 01 Nov 2019 21:50:03 GMT
kinow commented on a change in pull request #55: Add support to read multiple images from GIF
URL: https://github.com/apache/commons-imaging/pull/55#discussion_r341763476
 
 

 ##########
 File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
 ##########
 @@ -439,6 +439,16 @@ private GifBlock findBlock(final List<GifBlock> blocks, final
int code) {
         return null;
     }
 
+    private <T extends GifBlock> List<T> findAllBlocks(final List<GifBlock>
blocks, final int code) {
+        final List<T> filteredBlocks = new ArrayList<>();
+        for (final GifBlock gifBlock : blocks) {
+            if (gifBlock.blockCode == code) {
+                filteredBlocks.add((T) gifBlock);
 
 Review comment:
   Hmmm, this is tricky. We could have a malformed GIF that has a block with the wrong code,
resulting in a runtime exception here I think? Or if I request something like `List<ImageDescriptor>
descriptors = findAllBlocks(imageContents.blocks, GRAPHIC_CONTROL_EXTENSION);`. I wonder if
we could come up with a different approach to avoid issues like this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message