commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-imaging] kinow commented on a change in pull request #55: [IMAGING-236] Add support to read multiple images from GIF
Date Fri, 01 Nov 2019 22:57:11 GMT
kinow commented on a change in pull request #55: [IMAGING-236] Add support to read multiple
images from GIF
URL: https://github.com/apache/commons-imaging/pull/55#discussion_r341434351
 
 

 ##########
 File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageMetadata.java
 ##########
 @@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.imaging.formats.gif;
+
+import org.apache.commons.imaging.common.ImageMetadata;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+public class GifImageMetadata implements ImageMetadata {
+    private static final String NEWLINE = System.getProperty("line.separator");
+    private final int width;
+    private final int height;
 
 Review comment:
   From what I understand, these two are more like a "canvas" size (as in some graphic editors
like GIMP), while the internal images of the Gif file may vary in width and height, but always
within this boundaries.
   
   Maybe we should include `width` and `height` to each `GifImageMetadataItem`, and either
leave these two as-is adding some javadocs, or rename to `viewWidth`, `viewportWidth`, `canvasWidth`,
`screenWidth`, etc. WDYT/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message