commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [commons-imaging] kinow commented on a change in pull request #55: [IMAGING-236] Add support to read multiple images from GIF
Date Fri, 01 Nov 2019 23:13:30 GMT
kinow commented on a change in pull request #55: [IMAGING-236] Add support to read multiple
images from GIF

 File path: src/main/java/org/apache/commons/imaging/formats/gif/
 @@ -0,0 +1,54 @@
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.imaging.formats.gif;
+import org.apache.commons.imaging.common.ImageMetadata;
+public class GifImageMetadataItem implements ImageMetadata.ImageMetadataItem {
+    private static final String NEWLINE = System.getProperty("line.separator");
+    private final int delay;
+    private final int leftPosition;
+    private final int topPosition;
 Review comment:
   Maybe we should include the `width` and `height` of each gif image? Did a quick test, writing
each `BufferedImage` to disk. The `image` and `height` can be retrieved with something like
`id.descriptor.imageWidth` and `id.descriptor.imageHeight` in the parser.
   Not sure if really helpful, as we can also get the height and width directly from the buffered
image. What do you think @christoffer-rydberg? Do you think this could be useful to have in
the git image metadata item? 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message