commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-imaging] kinow commented on issue #55: [IMAGING-236] Add support to read multiple images from GIF
Date Fri, 01 Nov 2019 23:32:17 GMT
kinow commented on issue #55: [IMAGING-236] Add support to read multiple images from GIF
URL: https://github.com/apache/commons-imaging/pull/55#issuecomment-548983532
 
 
   @christoffer-rydberg finished reviewing it. Had a quick look at the specification, then
played with the code. Had added some comments yesterday on GitHub, then went through them
this morning discarding most of them as I read the code :coffee: 
   
   Left three, but I think only the one in the test file may need code change? Once you have
had time to reply or resolve the comments/reviews, it can be merged and should be in 1.0-alpha2
:+1: thanks!!!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message