commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-imaging] christoffer-rydberg commented on a change in pull request #55: [IMAGING-236] Add support to read multiple images from GIF
Date Sat, 02 Nov 2019 13:14:07 GMT
christoffer-rydberg commented on a change in pull request #55: [IMAGING-236] Add support to
read multiple images from GIF
URL: https://github.com/apache/commons-imaging/pull/55#discussion_r341810829
 
 

 ##########
 File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageMetadataItem.java
 ##########
 @@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.imaging.formats.gif;
+
+import org.apache.commons.imaging.common.ImageMetadata;
+
+public class GifImageMetadataItem implements ImageMetadata.ImageMetadataItem {
+    private static final String NEWLINE = System.getProperty("line.separator");
+    private final int delay;
+    private final int leftPosition;
+    private final int topPosition;
 
 Review comment:
   I only use the metadata to decide the delay and placement for each image. For that I need
the overall GIF width and height as well as the individual image offsets. As you say, you
can easily get the width and height from each buffered image. Maybe it could be useful if
you want to display such information before loading the actual images?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message