commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [commons-compress] PeterAlfreadLee commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files
Date Tue, 05 Nov 2019 08:25:19 GMT
PeterAlfreadLee commented on issue #84: COMPRESS-477 Add support for extracting splitted zip
files
URL: https://github.com/apache/commons-compress/pull/84#issuecomment-549714757
 
 
   > I agree it would be better to separate it into a new PR.
   > 
   > I'm not sure if/how the creation code would overlap with the reading code so guess
it wouldn't cause any merge conflicts if you started the new one in parallel but will leave
that up to you.
   
   Sure. I will separate it into another new PR.
   For now there are only some minor merge conflicts, most of them is some file utils like
`getBaseName`, and I will solve the conflicts when this PR is merged.
   
   Please let me know if the code need to be modified when you found something. Thank you
for your review @bodewig 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message