commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (IMAGING-236) Add support to read multiple images from GIF
Date Fri, 01 Nov 2019 22:59:00 GMT

     [ https://issues.apache.org/jira/browse/IMAGING-236?focusedWorklogId=337599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337599
]

ASF GitHub Bot logged work on IMAGING-236:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Nov/19 22:58
            Start Date: 01/Nov/19 22:58
    Worklog Time Spent: 10m 
      Work Description: kinow commented on pull request #55: [IMAGING-236] Add support to
read multiple images from GIF
URL: https://github.com/apache/commons-imaging/pull/55#discussion_r341434438
 
 

 ##########
 File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageMetadata.java
 ##########
 @@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.imaging.formats.gif;
+
+import org.apache.commons.imaging.common.ImageMetadata;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+public class GifImageMetadata implements ImageMetadata {
+    private static final String NEWLINE = System.getProperty("line.separator");
+    private final int width;
+    private final int height;
+    private final List<GifImageMetadataItem> items;
+
+    GifImageMetadata(int width, int height, List<GifImageMetadataItem> items) {
+        this.width = width;
+        this.height = height;
+        this.items = Collections.unmodifiableList(new ArrayList<>(items));
+    }
+
+    @Override
+    public String toString(String prefix) {
+        prefix = prefix == null ? "" : prefix;
+        final StringBuilder result = new StringBuilder();
+        result.append(String.format("%sGIF metadata:", prefix));
+        result.append(String.format("%sWidth: %d%s", prefix, width, NEWLINE));
+        result.append(String.format("%sHeight: %d%s", prefix, height, NEWLINE));
+        result.append(NEWLINE);
+        result.append(String.format("%sImages:", prefix));
+        for (GifImageMetadataItem item : items) {
+            result.append(NEWLINE);
+            result.append(item.toString(prefix));
+        }
+        return result.toString();
 
 Review comment:
   The `toString()` method here has a different output then, for example, the TIFF image metadata.
Would be better to use a similar output (maybe using the generic parent class would solve
it?).
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 337599)
    Time Spent: 0.5h  (was: 20m)

> Add support to read multiple images from GIF
> --------------------------------------------
>
>                 Key: IMAGING-236
>                 URL: https://issues.apache.org/jira/browse/IMAGING-236
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Format: GIF
>            Reporter: Bruno P. Kinoshita
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>             Fix For: 1.0-alpha2
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Placeholder for https://github.com/apache/commons-imaging/pull/55



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message