commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Work logged] (IMAGING-236) Add support to read multiple images from GIF
Date Fri, 01 Nov 2019 23:14:00 GMT

     [ https://issues.apache.org/jira/browse/IMAGING-236?focusedWorklogId=337608&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337608
]

ASF GitHub Bot logged work on IMAGING-236:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Nov/19 23:13
            Start Date: 01/Nov/19 23:13
    Worklog Time Spent: 10m 
      Work Description: kinow commented on pull request #55: [IMAGING-236] Add support to
read multiple images from GIF
URL: https://github.com/apache/commons-imaging/pull/55#discussion_r341762200
 
 

 ##########
 File path: src/main/java/org/apache/commons/imaging/formats/gif/GifImageMetadataItem.java
 ##########
 @@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.imaging.formats.gif;
+
+import org.apache.commons.imaging.common.ImageMetadata;
+
+public class GifImageMetadataItem implements ImageMetadata.ImageMetadataItem {
+    private static final String NEWLINE = System.getProperty("line.separator");
+    private final int delay;
+    private final int leftPosition;
+    private final int topPosition;
 
 Review comment:
   Maybe we should include the `width` and `height` of each gif image? Did a quick test, writing
each `BufferedImage` to disk. The `image` and `height` can be retrieved with something like
`id.descriptor.imageWidth` and `id.descriptor.imageHeight` in the parser.
   
   Not sure if really helpful, as we can also get the height and width directly from the buffered
image. What do you think @christoffer-rydberg? Do you think this could be useful to have in
the git image metadata item? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 337608)
    Time Spent: 1h 10m  (was: 1h)

> Add support to read multiple images from GIF
> --------------------------------------------
>
>                 Key: IMAGING-236
>                 URL: https://issues.apache.org/jira/browse/IMAGING-236
>             Project: Commons Imaging
>          Issue Type: Improvement
>          Components: Format: GIF
>            Reporter: Bruno P. Kinoshita
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>             Fix For: 1.0-alpha2
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Placeholder for https://github.com/apache/commons-imaging/pull/55



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message