cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <>
Subject [jira] [Resolved] (CB-5105) remove dead code for device.version from native plugin source
Date Mon, 03 Mar 2014 19:14:23 GMT


Andrew Grieve resolved CB-5105.

    Resolution: Fixed

fixed in 0.2.9-dev

> remove dead code for device.version from native plugin source
> -------------------------------------------------------------
>                 Key: CB-5105
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Device
>    Affects Versions: 3.1.0
>            Reporter: Marcel Kinard
>            Assignee: Martin Gonzalez
>            Priority: Minor
> The solution for CB-5085 (and related) is for device.js to set device.cordova using CORDOVA_JS_BUILD_LABEL
from cordova.js, instead of having native code do that (usually with hardcoded values) and
return it back from exec(). So once CB-5085 is fixed in this way, then any native code that
computes device.version is dead. That dead code should be removed from cordova-plugin-device,
if for no other reason than reducing confusion.
> The following platforms are affected: Android, BB10, WP8, Win8.
> iOS is doing something special, but doing it right, so don't make any changes to iOS.

This message was sent by Atlassian JIRA

View raw message