[ https://issues.apache.org/jira/browse/CB-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947755#comment-13947755
]
ASF GitHub Bot commented on CB-6350:
------------------------------------
GitHub user yannlugrin opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/8
[CB-6350] Return cellular connection type even if wifi is reachable on 64-bit iOS
Pull request related to:
https://issues.apache.org/jira/browse/CB-6350
This path resolve issue by using NetworkStatus type instead of BOOL, because BOOL is now
actually bool on 64-Bit iOS and cannot be used in this case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yannlugrin/cordova-plugin-network-information fix_wifi_detection_on_ios7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-network-information/pull/8.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8
----
commit 76a405827e8603c92f58a670539e04ca9d4d1a35
Author: Yann Lugrin <yann.lugrin@liquid-concept.ch>
Date: 2014-03-26T09:59:25Z
Fix networkStatusForFlags return value type to work with 64-bit iOS
----
> Return cellular connection type even if wifi is reachable on 64-bit iOS
> -----------------------------------------------------------------------
>
> Key: CB-6350
> URL: https://issues.apache.org/jira/browse/CB-6350
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin Network Information
> Reporter: Yann Lugrin
>
> When we get connection type on 64-bit iOS, return value is set to cellular event if wifi
is reachable.
> On 64-bit iOS, "BOOL" is now the same as "bool", and the return type of networkStatusForFlags
method cannot use this type anymore. Using "NetworkStatus" type resolve this issue.
> source on 64-bit iOS BOOL change: http://blog.bignerdranch.com/564-bools-sharp-corners/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
|