cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-2520) iOS: "original" user agent needs to be overridable
Date Sun, 05 Oct 2014 03:19:34 GMT

    [ https://issues.apache.org/jira/browse/CB-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159408#comment-14159408
] 

ASF GitHub Bot commented on CB-2520:
------------------------------------

GitHub user khawkins opened a pull request:

    https://github.com/apache/cordova-ios/pull/112

    Creating a customizable user agent for iOS

    Fix for [CB-2520](https://issues.apache.org/jira/browse/CB-2520). Presumably, we'd eventually
want a more user-exposed entry path to this. But this work should be a good first step to
that.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khawkins/cordova-ios CB-2520

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
    
----
commit 36476a8c0dd6f1ae07e519a3752ececc5228f3df
Author: Kevin Hawkins <khawkins@salesforce.com>
Date:   2014-10-05T02:45:54Z

    Creating a customizable user agent

commit 661f87d404cd17c43515cc259a69a8c111750313
Author: Kevin Hawkins <khawkins@salesforce.com>
Date:   2014-10-05T03:16:52Z

    Making baseUserAgent an instance property

----


> iOS: "original" user agent needs to be overridable
> --------------------------------------------------
>
>                 Key: CB-2520
>                 URL: https://issues.apache.org/jira/browse/CB-2520
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Kevin Hawkins
>              Labels: core
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> Cordova's user agent management for iOS employs a scheme of setting a baseline "original"
user agent, which by default conforms to the standard user agent a UIWebView would expose,
and then optionally appending CDVViewController-specific data to it in the appropriate use
cases, to manage whitelisting.
> Cordova shouldn't really care too much about the data that the original user agent exposes.
 I.e. it should be able to be overridden by a consumer, so that the consumer can supply its
own user agent data.  This is not technically possible with the current implementation of
the CDVUserAgentUtil class, since it does not exist as a member of any instance class; it's
truly static/global, so inheritance doesn't come into play.
> Even if an instance of CDVuserAgentUtil could be made a property of CDVViewController,
or something else, it would be kind of weird for a consumer to inherit from what's essentially
a static class, just to configure their own user agent data.
> There should be another mechanism for users to override the original user agent configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message