cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7607) Add xxhdpi and xxxhdpi support to Android Cordova
Date Thu, 02 Oct 2014 23:19:34 GMT

    [ https://issues.apache.org/jira/browse/CB-7607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14157388#comment-14157388
] 

ASF GitHub Bot commented on CB-7607:
------------------------------------

GitHub user dpogue opened a pull request:

    https://github.com/apache/cordova-lib/pull/97

    xxhdpi/xxxhdpi and 9-patch splash image support for Android

    This combines #89 and #87 so that they won't conflict with each other.
    /cc @sgrebnov 
    
    From #89:
    > https://issues.apache.org/jira/browse/CB-7607
    >
    > Current Cordova template for Android does not have res sub-folders for xx and xxxhdpi
plus due to current
    > splash/icons support implementation it is possible to replace already existing drawables
only(see var 
    > densities = this.deleteDefaultResource(...)). I don't think we should always keep
new hi res images as part
    > of default template due to the their big size so this commit improves splash/icons
support implementation
    > to make it possible to add drawables for the densities which are not present in template
by default.
    >
    > Example configuration for xxhdpi and xxxhdpi assets:
    >
    > ```
    > <icon src="res/android/xxhdpi.png" density="xxhdpi" />
    > <icon src="res/android/xxxhdpi.png" density="xxxhdpi" />
    >
    > <splash src="res/android/land-xxhdpi.png" density="land-xxhdpi" />
    > <splash src="res/android/port-xxhdpi.png" density="port-xxhdpi" />
    >
    > <splash src="res/android/land-xxxhdpi.png" density="land-xxxhdpi" />
    > <splash src="res/android/port-xxxhdpi.png" density="port-xxxhdpi" />
    > ```
    
    From #87:
    > https://issues.apache.org/jira/browse/CB-7598
    >
    > If a splashscreen image for Android is specified in config.xml and ends with .9.png,
it is a 9-patch image
    > and should retain that extension when copied into the platforms/android directory.
    >
    > Currently the file will be renamed to screen.png when it should be screen.9.png.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpogue/cordova-lib android-resources

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #97
    
----
commit 0cbb047f37ca275c07b8ef033807263fd580c571
Author: sgrebnov <v-segreb@microsoft.com>
Date:   2014-09-22T18:13:57Z

    CB-7607 Add xxhdpi and xxxhdpi support to Android Cordova

commit e1c9537d5d1640981b0cb1e56de5441db040ea05
Author: Darryl Pogue <dvpdiner2@gmail.com>
Date:   2014-10-02T23:10:53Z

    CB-7598 Support for 9-patch Android splash images

----


> Add xxhdpi and xxxhdpi support to Android Cordova
> -------------------------------------------------
>
>                 Key: CB-7607
>                 URL: https://issues.apache.org/jira/browse/CB-7607
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, CordovaLib
>            Reporter: Sergey Grebnov
>              Labels: android, assets, cordova-lib, icons, splashscreen
>
> xxhdpi and xxxhdpi support is missing from Android Cordova implementation (icons and
splash images)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message