cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
Date Wed, 01 Oct 2014 00:58:35 GMT

    [ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154142#comment-14154142
] 

ASF subversion and git services commented on CB-7674:
-----------------------------------------------------

Commit 90766ae0faa6594a6f4d6b9d61d66af8e3600b8e in cordova-android's branch refs/heads/3.6.x
from [~cmarcelk]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=90766ae ]

CB-7674 move preference activation back into onCreate()

The preference creation actually needs to be before
super.onCreate(savedInstance) in order to avoid the exception
"requestFeature() must be called before adding content". Also ran into an
issue in the native tests "Whitelist" and "User WebView/Client/Chrome" where
it would throw an exception that the CordovaWebView appView already had
a parent and needed to be removed from that parent before the invocation
to root.addView(appView). So I conditionally remove the wrong parent.
Also made a change to the native tests so the menus test would work.
I also put super.init() back into the template, though invoking it is optional
as loadUrl will call it automatically if needed.


> Preference activation no longer occurs in CordovaActivity.onCreate()
> --------------------------------------------------------------------
>
>                 Key: CB-7674
>                 URL: https://issues.apache.org/jira/browse/CB-7674
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 3.6.0
>            Reporter: Marcel Kinard
>            Assignee: Marcel Kinard
>            Priority: Blocker
>
> During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate()
to move the activation of preferences to CordovaActivity.init(). For applications that were
relying on the activation of preferences in onCreate(), those preferences are no longer active
when onCreate() completes, and may break those applications. Although it is described as a
"subtle change to the API surface" in the commit message, this is a breaking change to a public
API.
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803
> http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message