cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Bowser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7674) Preference activation no longer occurs in CordovaActivity.onCreate()
Date Wed, 01 Oct 2014 01:01:34 GMT

    [ https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154148#comment-14154148
] 

Joe Bowser commented on CB-7674:
--------------------------------

The recent tests for 3.5.1 broke since this slows down the launch of one of the tests.  I
added sleep to get the test to work, so it's pretty minor.  I think keeping the API the same
is more important than a second here or there on the 3.x branch.  I'm cool with keeping the
change on 4.0.x though.

> Preference activation no longer occurs in CordovaActivity.onCreate()
> --------------------------------------------------------------------
>
>                 Key: CB-7674
>                 URL: https://issues.apache.org/jira/browse/CB-7674
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 3.6.0
>            Reporter: Marcel Kinard
>            Assignee: Marcel Kinard
>            Priority: Blocker
>
> During the 3.6.0 development timeframe, a modification was made to CordovaActivity.onCreate()
to move the activation of preferences to CordovaActivity.init(). For applications that were
relying on the activation of preferences in onCreate(), those preferences are no longer active
when onCreate() completes, and may break those applications. Although it is described as a
"subtle change to the API surface" in the commit message, this is a breaking change to a public
API.
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803
> http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message