cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9436) Refactor browserify to get rid of `require-tr` transform
Date Tue, 04 Aug 2015 01:45:04 GMT

    [ https://issues.apache.org/jira/browse/CB-9436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652935#comment-14652935
] 

ASF GitHub Bot commented on CB-9436:
------------------------------------

Github user stevengill commented on the pull request:

    https://github.com/apache/cordova-lib/pull/275#issuecomment-127452233
  
    Vladimir! This is a much needed refactor and it looks great! Thank you! The previous spaghetti
code was becoming hard to manage and understand. 
    
    Things I like:
    * Using `cordova_plugins.js` in the browserify build and removing `cordova_requires`
    * Adding the module name field in `cordova_plugins.js` for each module.
    * Using browserify expose to map `cordova/plugin_list` to `cordova_plugins.js`. (Didn't
even know about expose)
    * Great find with aliasify! Much cleaner way to handle the bad legacy requires in plugins
compared to using requiresTr.
    
    Quick Question without digging to deep:
    * Wondering why you had to add require('codrdova/init') to the bundle? https://github.com/MSOpenTech/cordova-lib/commit/510516135ef41b735b2e610c1b8d95fc77bd571e#diff-28a16640f3807e6ee2300ea7ce8c2f1dR196.
How was that getting added previously? 
    
    I think you fixed all of the remaining bugs with your changes. @surajpindoria will continue
to test on all of the devices we have here to see if we can find bugs.
    
    I am going to dive deeper into your cordova.js changes now.



> Refactor browserify to get rid of `require-tr` transform
> --------------------------------------------------------
>
>                 Key: CB-9436
>                 URL: https://issues.apache.org/jira/browse/CB-9436
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaJS, CordovaLib
>            Reporter: Vladimir Kotikov
>            Assignee: Vladimir Kotikov
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message