cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-9443) Windows camera picks incorrect maxResolution
Date Mon, 03 Aug 2015 21:26:04 GMT


ASF GitHub Bot commented on CB-9443:

Github user muratsu commented on the pull request:
    Sorry didn't see your comment earlier. 
    In terms of perf, I think this the usage of `if/else` vs `switch` is not really important
here. Since we're only executing it once, the perf difference is not going to be noticable
either case.
    Readability is a bit more subjective - I don't have a preference in this case. I tend
to use switches only when I have fall-through cases. 
    I wasn't familiar with `switch(true)` pattern. It seemed like an anti-pattern to me at
first but looks like it is a common pattern in dynamic languages. I'll revert it back to switch.

> Windows camera picks incorrect maxResolution
> --------------------------------------------
>                 Key: CB-9443
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>         Environment: Windows Desktop, Windows Phone 10
>            Reporter: Murat Sutunc
>            Assignee: Murat Sutunc
>              Labels: Windows

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message