cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9450) During Build, set publisherId according to packaging configuration (build.json)
Date Wed, 05 Aug 2015 15:49:06 GMT

    [ https://issues.apache.org/jira/browse/CB-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658411#comment-14658411
] 

ASF GitHub Bot commented on CB-9450:
------------------------------------

GitHub user robpaveza opened a pull request:

    https://github.com/apache/cordova-windows/pull/111

    CB-9450: Added a manifest munge step during build that updates app...

    ...manifests with build and packaging parameters.  Also added the new
    `WindowsStoreIdentityName` preference which adds the ability to set that
    publishing property, since the Windows Store app identity is assigned by
    the Store.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-windows CB-9450

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #111
    
----
commit eb0d2b09c4c9d66bfcde0c4fe344f1463b3bfccd
Author: Rob Paveza <rob.paveza@microsoft.com>
Date:   2015-08-04T23:38:16Z

    CB-9450: Added a manifest munge step during build that updates app
    manifests with build and packaging parameters.  Also added the new
    `WindowsStoreIdentityName` preference which adds the ability to set that
    publishing property, since the Windows Store app identity is assigned by
    the Store.

----


> During Build, set publisherId according to packaging configuration (build.json)
> -------------------------------------------------------------------------------
>
>                 Key: CB-9450
>                 URL: https://issues.apache.org/jira/browse/CB-9450
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>            Reporter: Rob Paveza
>            Assignee: Rob Paveza
>
> Presently, the `<Identity Publisher>` attribute is not set by either build or prepare.
 The value of this attribute should be coming from publisherId parameter or build.json, but
because build.json parameters are only set during build, but we don't update the .appxmanifest
during build, it never gets set.
> This change will be to set the appxmanifest publisher if the publisher is updated during
build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message