From issues-return-46999-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org Tue Aug 4 22:50:05 2015 Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 451AA18FC7 for ; Tue, 4 Aug 2015 22:50:05 +0000 (UTC) Received: (qmail 34863 invoked by uid 500); 4 Aug 2015 22:50:05 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 34835 invoked by uid 500); 4 Aug 2015 22:50:05 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 34815 invoked by uid 99); 4 Aug 2015 22:50:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Aug 2015 22:50:05 +0000 Date: Tue, 4 Aug 2015 22:50:05 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-9436) Refactor browserify to get rid of `require-tr` transform MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-9436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654499#comment-14654499 ] ASF GitHub Bot commented on CB-9436: ------------------------------------ Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-js/pull/124#discussion_r36251972 --- Diff: tasks/lib/packager-browserify.js --- @@ -46,25 +37,13 @@ module.exports = function generate(platform, useWindowsLineEndings, platformVers outReleaseFile = path.join('pkg', 'cordova.' + platform + '.js'); outReleaseFileStream = fs.createWriteStream(outReleaseFile); - var symbolList = null; - var addSymbolList = through.obj(function(row, enc, next) { - if(symbolList === null) { - symbolList = requireTr.getModules(platform); - this.push(util.format('var symbolList = %s;\n%s\n', JSON.stringify(symbolList, null, 4), row)); - } else { - this.push(row); - } - next(); - }); - - libraryRelease.pipeline.get('wrap').push(addSymbolList); - // write license header writeLicenseHeader(outReleaseFileStream, platform, commitId, platformVersion); - releaseBundle = libraryRelease.bundle(); - - releaseBundle.pipe(outReleaseFileStream); + bundle(platform, false, commitId, platformVersion, platformPath) + .add(path.resolve(__dirname, '..', '..', 'src/scripts/bootstrap.js')) --- End diff -- Yes, they both needed. This was moved from `bundle-browserify.js` direcly to `cordova-lib/prepare-browserify` due to some reasons (see https://github.com/apache/cordova-lib/pull/275#issuecomment-127782310) but we still need to add this file when building clean cordova-js bundle (without plugins) from grunt task. > Refactor browserify to get rid of `require-tr` transform > -------------------------------------------------------- > > Key: CB-9436 > URL: https://issues.apache.org/jira/browse/CB-9436 > Project: Apache Cordova > Issue Type: Improvement > Components: CordovaJS, CordovaLib > Reporter: Vladimir Kotikov > Assignee: Vladimir Kotikov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org