cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7021) mobilespec missing test cases for navigator.contacts.pickContact
Date Thu, 19 Nov 2015 13:11:10 GMT

    [ https://issues.apache.org/jira/browse/CB-7021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013504#comment-15013504
] 

ASF GitHub Bot commented on CB-7021:
------------------------------------

Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/83#discussion_r45337850
  
    --- Diff: tests/tests.js ---
    @@ -525,6 +525,28 @@ exports.defineManualTests = function(contentEl, createActionButton)
{
             }, obj);
         }
     
    +    function pickContact() {
    +        var results = document.getElementById('contact_results');
    +        navigator.contacts.pickContact(
    +            function (contact) {
    +                var s = "";
    +                if (!contact)
    --- End diff --
    
    Nit: Embrace into curly braces.


> mobilespec missing test cases for navigator.contacts.pickContact
> ----------------------------------------------------------------
>
>                 Key: CB-7021
>                 URL: https://issues.apache.org/jira/browse/CB-7021
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Contacts
>    Affects Versions: Master
>            Reporter: Carlos Santana
>            Assignee: Vladimir Kotikov
>              Labels: easyfix, triaged
>
> mobilespec missing test cases for navigator.contacts.pickContact
> manual test /contacts/index.js missing tests for navigator.contacts.pickContact



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message