cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7696) External links are mistakenly opening via system browser instead of InAppBrowser
Date Thu, 19 Nov 2015 13:30:11 GMT

    [ https://issues.apache.org/jira/browse/CB-7696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013533#comment-15013533
] 

ASF GitHub Bot commented on CB-7696:
------------------------------------

GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/124

    CB-7696 Document target=_self behavior for Windows

    Documenting Windows behavior as per https://issues.apache.org/jira/browse/CB-7696

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-inappbrowser CB-7696

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124
    
----
commit 8c0487f0d7a2098ff6308af6c82288388f085873
Author: Sergey Grebnov <sergei.grebnov@gmail.com>
Date:   2015-11-19T13:27:11Z

    CB-7696 Document target=_self behavior for Windows

----


> External links are mistakenly opening via system browser instead of InAppBrowser
> --------------------------------------------------------------------------------
>
>                 Key: CB-7696
>                 URL: https://issues.apache.org/jira/browse/CB-7696
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin InAppBrowser
>         Environment: 'windows' platform, Windows 8.0, 8.1, Windows Phone 8.1
>            Reporter: Sergey Shakhnazarov
>            Assignee: Sergey Grebnov
>              Labels: Triaged, Windows
>
> 1. Run Mobilespec app
> 2. Go to Plugin Tests (Automatic and manual)
> 3. Go to “manual tests”
> 4. Go to “cordova.inappbrowser.tests.tests”
> 5. Click on of these buttons
> White Listed URL 
> "target=Random" button
> Expected result: open successfully in InAppBrowser to www.google.com
> Actual: opens link in a system browser
> "* target=Random, no location bar" button
> Expected result: open successfully in InAppBrowser to www.google.com with no location
bar.
> Actual: opens link in a system browser
> Non White Listed URL
> target=Default
> Expected result: open successfully in InAppBrowser to apple.com (_self enforces whitelist).
> Actual: opens link in a system browser
> target=_self
> Expected result: open successfully in InAppBrowser to apple.com (_self enforces whitelist).
> Actual: opens link in a system browser
> target=Random
> Expected result: open successfully in InAppBrowser to apple.com.
> Actual: opens link in a system browser
> * target=Random, no location bar
> Expected result: open successfully in InAppBrowser to apple.com without locationBar.
> Actual: opens link in a system browser



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message