cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-8350) Android alias applicationDirectory is not readable
Date Wed, 04 Nov 2015 18:30:28 GMT

    [ https://issues.apache.org/jira/browse/CB-8350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14990119#comment-14990119
] 

ASF subversion and git services commented on CB-8350:
-----------------------------------------------------

Commit 76c8fd5e43598ea660c2db64eb08e2659b45a575 in cordova-plugin-file's branch refs/heads/master
from [~jasongin]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=76c8fd5 ]

Fix CB-9752: getDirectory fails on valid directory with assets filesystem

Calls to FileEntry.getDirectory() on an asset entry would internally call
the AssetFileSystem.listAssets() method using an asset path with a
trailing slash, regardless of whether a trailing slash was included by
the user. But neither the asset list cache (from cdvasset.manifest) nor
Android's AssetManager.list() API support matching a path with a trailing
slash. That resulted in a TypeMismatchException thrown from
AssetFileSystem.getFileForLocalURL(), because the asset path was found
but not matched as a directory as expected by the caller.

This fix removes the trailing slash from the asset path before matching
against the asset list cache or calling Android's AssetManager.list() API.
A new unit test for getting asset directories fails without and passes
with the fix.

While I'm here, I'm also adding a unit test for reading asset file
contents. There are a couple old bug reports about that (CB-7273,
CB-8350). The bugs don't repro anymore, but I'm adding the test anyway
since there wasn't good test coverage before.


> Android alias applicationDirectory is not readable
> --------------------------------------------------
>
>                 Key: CB-8350
>                 URL: https://issues.apache.org/jira/browse/CB-8350
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>            Reporter: Raymond Camden
>            Assignee: Jason Ginchereau
>            Priority: Minor
>
> The table for Android File System Layout shows cordova.file.applicationDirectory as being
readable. While technically it is readable via XHR, the implication is that it is readable
by the FileSystem APIs, and it is not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message