cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-9969) Windows filetransfer upload error deletes original file.
Date Thu, 19 Nov 2015 12:00:16 GMT

    [ https://issues.apache.org/jira/browse/CB-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013414#comment-15013414
] 

ASF GitHub Bot commented on CB-9969:
------------------------------------

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/115

    CB-9969 Filetransfer upload error deletes original file

    Adds a corresponding test and fixes for Android, iOS and Windows.
    
    [Jira issue](https://issues.apache.org/jira/browse/CB-9969)
    
    Also fixes `filetransfer.spec.9`, which used an incorrect path in the `root.getFile` call.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer CB-9969

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit a806454d621bc6b1853d461ff1f6c169a4092834
Author: daserge <v-seshak@microsoft.com>
Date:   2015-11-19T11:45:26Z

    CB-9969 Filetransfer upload error deletes original file
    
    Adds corresponding test and fixes for Android, iOS and Windows

----


> Windows filetransfer upload error deletes  original file. 
> ----------------------------------------------------------
>
>                 Key: CB-9969
>                 URL: https://issues.apache.org/jira/browse/CB-9969
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>         Environment: windows
>            Reporter: Wema Wuyts
>
> The upload function on windows has an onerror handler:
>   getTransferError.then(function(transferError) {
>     storageFile.deleteAsync().then(function() {
>     errorCallback(transferError);
>   });
> });
> think this should be :
>  getTransferError.then(function(transferError) {
>      errorCallback(transferError);
> });



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message