cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-6576) Return a specific error message when app has no access to Photos
Date Thu, 03 Dec 2015 18:36:11 GMT

    [ https://issues.apache.org/jira/browse/CB-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15038271#comment-15038271
] 

ASF GitHub Bot commented on CB-6576:
------------------------------------

GitHub user nleclerc opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/144

    [iOS] Fixed authorization error when user clicks cancel in image selector view.

    I'm resurrecting a change from [an old pull request](https://github.com/apache/cordova-plugin-camera/pull/24)
that was closed without any explanation.
    
    [The original issue](https://issues.apache.org/jira/browse/CB-6576) has been improperly
marked as resolved when it clearly is not.
    
    Problem is there's currently no way to know when a user has just cancelled the image capture
since clicking cancel send a `has no access to assets` error when it really isn't an authorization
issue.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nleclerc/cordova-plugin-camera ios-cancel-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
    
----
commit c34a6fdc18aaf12aab6c0c43e03bc9c63267b895
Author: Nicolas Leclerc <nl@spirotron.fr>
Date:   2015-12-03T18:19:27Z

    iOS: Fixed plugin sending authorization error when user clicks cancel in image selector
view.

----


> Return a specific error message when app has no access to Photos
> ----------------------------------------------------------------
>
>                 Key: CB-6576
>                 URL: https://issues.apache.org/jira/browse/CB-6576
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Camera
>         Environment: iOS
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>
> If the user cancels the UIImagePickerController and the app has no authorization to access
to the Photos, an error with the message "has no access to assets" is returned as the plugin
result.
> https://github.com/apache/cordova-plugin-camera/pull/24
> Note that  [ALAssetsLibrary authorizationStatus] is iOS 6 only, we will need to add an
engines tag with an "apple-ios" key (separate issue).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message