cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-9519) Inappropriate destruction time of engine in CordovaWebViewImpl
Date Tue, 01 Dec 2015 19:47:10 GMT


ASF GitHub Bot commented on CB-9519:

Github user infil00p commented on the pull request:
    Can this be added to master and not to 4.0.x?

> Inappropriate destruction time of engine in CordovaWebViewImpl
> --------------------------------------------------------------
>                 Key: CB-9519
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>            Reporter: Dong Hanlin
>            Assignee: Vladimir Kotikov
> In {{}}, one of the TODO comments in {{public void handleDestroy()}}
method points out that the engine should not destroy webview until after about:blank is done
loading. Actually, the engine has indeed been destroyed before about:blank is completely loaded,
which causes some problems.
> I think moving a line of code may work:
> {quote}
> engine.destroy();
> {quote}
> This code can be moved into the last {{if}} block in {{public void onPageFinishedLoading(String
url)}}, like this:
> {code}
>             // Shutdown if blank loaded
>             if (url.equals("about:blank")) {
>                 engine.destroy();
>                 pluginManager.postMessage("exit", null);
>             }
> {code}
> Since before destroying the engine, we have set the URL to be about:blank, so destroying
it when about:blank is completed loaded can work.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message