cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10039) Problem add Contact photos from relative and absolute path for Android
Date Thu, 03 Dec 2015 10:54:11 GMT

    [ https://issues.apache.org/jira/browse/CB-10039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037658#comment-15037658
] 

ASF GitHub Bot commented on CB-10039:
-------------------------------------

Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161597318
  
    @riknoll, other platforms (iOS, Windows) don't try to resolve relative paths. Instead
they expect image path/URI to be absolute. Probably we should follow the same rule here. However,
we still need to threat `file:///android_asset` URIs differently, so the condition `if (path.startsWith(ASSET_URL_PREFIX))
... ` is still actual. Thoughts?


> Problem add Contact photos from relative and absolute path for Android
> ----------------------------------------------------------------------
>
>                 Key: CB-10039
>                 URL: https://issues.apache.org/jira/browse/CB-10039
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Contacts
>         Environment: Android
>            Reporter: vincipop
>            Assignee: Vladimir Kotikov
>            Priority: Minor
>              Labels: Android
>             Fix For: Master
>
>
> problem add Contact photos from relative and absolute path for Android: Get input stream
from relative and full path in ContactAccessorSdk.java
> Solved, attempt to merge on Github.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message