cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10064) Camera.getPicture - Wrong FileURI
Date Wed, 02 Dec 2015 19:41:11 GMT

    [ https://issues.apache.org/jira/browse/CB-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036458#comment-15036458
] 

ASF GitHub Bot commented on CB-10064:
-------------------------------------

Github user riknoll commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161410396
  
    Thanks for submitting a PR! I actually just ran into this issue while working on [another
issue in JIRA](https://issues.apache.org/jira/browse/CB-10064). After doing some research
into this problem, I found that it actually only comes up if you have the CAMERA permission
declared in your manifest (I have no idea what the reasoning behind this behavior is). We
don't declare that permission, but third party plugins can insert entries into the manifest
and so we still need to handle the case. Anyway, the question is, should we always request
the camera permission or should we check the manifest for the permission declaration first?
I'm leaning towards checking the manifest (we shouldn't get extra permissions for no reason).
@infil00p thoughts on that?


> Camera.getPicture - Wrong FileURI
> ---------------------------------
>
>                 Key: CB-10064
>                 URL: https://issues.apache.org/jira/browse/CB-10064
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Camera
>    Affects Versions: 5.3.3
>         Environment: Android 6.0
>            Reporter: graphefruit
>              Labels: android
>         Attachments: log_error.txt
>
>
> Hello!
> if you take a picture with cordova and need to edit the picture, you won't get the edited
image-file-uri if the quality is set to "100".
> {code:javascript}
>  navigator.camera.getPicture(onSuccess, onFail, {
>                     quality: 100,
>                     destinationType: Camera.PictureSourceType.CAMERA,
>                     sourceType: sourceTypeCamera.DestinationType.NATIVE_URI
>                     allowEdit: true,
>                     encodingType: Camera.EncodingType.PNG,
>                     mediaType: window.Camera.MediaType.PICTURE,
>                     targetWidth: 0,
>                     targetHeight: 0,
>                     popoverOptions: CameraPopoverOptions,
>                     saveToPhotoAlbum: false
>                 });
> {code}
> If the quality is set to 99 the original image will be overwritten with the edited image
content and another image is created and saved with the edited image content.
> At least you can then use the edited image.
> Suggestion:
> Pass two parameters 
> {code:javascript}
> function onSuccess(_originalURI,_editedURI)
> {
> }
> {code}
> Edit 2:
> The SourceType: NATIVE_URI and FILE_URI are affected
> Thanks & Greetings
> Graphefruit



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message