cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11926) File-transfer tests should be able to use local file server
Date Mon, 03 Oct 2016 17:17:20 GMT

    [ https://issues.apache.org/jira/browse/CB-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542898#comment-15542898
] 

ASF GitHub Bot commented on CB-11926:
-------------------------------------

GitHub user alsorokin opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/159

    CB-11926 Tests can use local server

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    All
    
    ### What does this PR do?
    Allows tests to use a locally deployed server. You can specify its address via `--variable
FILETRANSFER_SERVER_ADDRESS=http://your.address.here:5000` upon plugin installation.
    The server itself can be found at:
    https://github.com/apache/cordova-labs/tree/cordova-filetransfer
    However, it's easier to just use paramedic, which can deploy this server and patch the
tests to use it automatically:
    https://github.com/apache/cordova-paramedic/pull/17
    
    ### What testing has been done on this change?
    Tested w/ and w/o paramedic on Android and Windows platforms.
    
    ### Checklist
    - [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to
secretary@apache.org.
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alsorokin/cordova-plugin-file-transfer local-server

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #159
    
----
commit ca293bd3f29dc74f628721a552ff91593380d81e
Author: Alexander Sorokin <alexander.sorokin@akvelon.com>
Date:   2016-09-30T16:20:41Z

    CB-11926 Tests can use local server

----


> File-transfer tests should be able to use local file server
> -----------------------------------------------------------
>
>                 Key: CB-11926
>                 URL: https://issues.apache.org/jira/browse/CB-11926
>             Project: Apache Cordova
>          Issue Type: Test
>          Components: Paramedic, Plugin File Transfer
>            Reporter: Alexander Sorokin
>            Assignee: Alexander Sorokin
>            Priority: Minor
>              Labels: triaged
>
> File-transfer tests should be able to use locally running file server instead of relying
only on Apache infrastructure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message