cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11028) Android version of the contacts plugin behaves differently for Contact Detail "type"
Date Wed, 02 Nov 2016 12:46:59 GMT

    [ https://issues.apache.org/jira/browse/CB-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628857#comment-15628857
] 

ASF GitHub Bot commented on CB-11028:
-------------------------------------

Github user alsorokin commented on the issue:

    https://github.com/apache/cordova-plugin-contacts/pull/136
  
    LGTM


> Android version of the contacts plugin behaves differently for Contact Detail "type"
> ------------------------------------------------------------------------------------
>
>                 Key: CB-11028
>                 URL: https://issues.apache.org/jira/browse/CB-11028
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Contacts
>            Reporter: Tobias M├╝cksch
>            Assignee: Nikita Matrosov
>              Labels: Android, triaged
>
> After inspecting the code for the android version of the plugin, I found out, that for
some reason the coders decided to return { ..., type: "custom", ... } for contact details
with custom labels. But the iOS Version returns the actual custom label as type.
> Example:
> *iOS:*
> {code:javascript}
> {
>     name: [ ... ],
>     phoneNumbers: [{
>         id: 1337,
>         type: "My super fancy label",
>         value: "+41 45654 214654"
>     }]
> }
> {code}
> *Android:*
> {code:javascript}
> {
>     name: [ ... ],
>     phoneNumbers: [{
>         id: 1337,
>         type: "custom",     // WHAT THE HECK?
>         value: "+41 45654 214654"
>     }]
> }
> {code}
> This behaviour is not exclusive to phoneNumbers. It's the same for all ContactDetails.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message