cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Bowser (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CB-11374) Support applicationId for android on config.xml
Date Wed, 02 Nov 2016 20:34:58 GMT

    [ https://issues.apache.org/jira/browse/CB-11374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15630375#comment-15630375
] 

Joe Bowser edited comment on CB-11374 at 11/2/16 8:34 PM:
----------------------------------------------------------

[~kikoalemao] Yes.  It might land sooner, but to get everything working properly, I need to
make sure that config.xml propagates through the GradleBuilder, and the GradleBuilder already
has a lot of problems and a lot of old dependencies on the project.properties file.

Currently there's a cordova-plugin-camera branch that uses the preference as a backup in case
someone decides to use ProGuard with Cordova and mungs up the BuildConfig class where we can
get the applicationId programmatically, but that's all the preference is currently used for
right now.  I'm certain any plugin that implements a Content provider will also need the applicationId,
and that this is no longer a nice to have but is a mandatory option.

If this fix was easier, I'd get it out sooner, but I think that we're going to have to break
some stuff to get this in properly.


was (Author: bowserj):
[~kikoalemao] Yes.  It might land sooner, but to get everything working properly, I need to
make sure that config.xml propagates through the GradleBuilder, and the GradleBuilder already
has a lot of problems and a lot of old dependencies on the project.properties file.

Currently there's a cordova-plugin-camera branch that uses the preference as a backup in case
someone decides to use ProGuard with Cordova and mungs up the BuildConfig class where we can
get the applicationId programmatically, but that's all the preference is currently used for
right now.  I'm certain any plugin that implements a Content provider will also need the applicationId,
and that this is no longer a nice to have but is a mandatory option.

> Support applicationId for android on config.xml
> -----------------------------------------------
>
>                 Key: CB-11374
>                 URL: https://issues.apache.org/jira/browse/CB-11374
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>    Affects Versions: 6.2.0
>            Reporter: Frederico Costa Galv√£o
>            Assignee: Joe Bowser
>            Priority: Critical
>
> After discovering these hidden/undocumented options \[1\], while trying to set up my
cordova project to be whitelabel-friendly, I realized that a *android-applicationId* setting
should be made available on config.xml now that android decoupled *applicationId* from *packageName*.
> An initial PR related to this topic was https://github.com/apache/cordova-android/pull/247,
but the "more robust" thing was left for later. This second step should be fairly easy to
set up, I guess.
> \[1\] https://issues.apache.org/jira/browse/CB-11373



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message