cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12049) Cordova iOS user-agent string has a unique number appended
Date Tue, 01 Nov 2016 23:01:59 GMT

    [ https://issues.apache.org/jira/browse/CB-12049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626961#comment-15626961
] 

ASF GitHub Bot commented on CB-12049:
-------------------------------------

GitHub user sterlingann opened a pull request:

    https://github.com/apache/cordova-ios/pull/272

    CB-12049 user-agent string has a unique number appended

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    ios
    
    ### What does this PR do?
    
    removes the user agent unique number
    ### What testing has been done on this change?
    
    automated NPM test
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sterlingann/cordova-ios CB-12049-b

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/272.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #272
    
----
commit fec2e703579984319e4c343aa96e49b5e0e8932a
Author: Sterling <sterlingann@gmail.com>
Date:   2016-11-01T22:15:08Z

    CB-12049 user-agent string has a unique number appended

----


> Cordova iOS user-agent string has a unique number appended
> ----------------------------------------------------------
>
>                 Key: CB-12049
>                 URL: https://issues.apache.org/jira/browse/CB-12049
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Jay Caines-Gooby
>            Priority: Trivial
>              Labels: EasyFix, Triaged
>
> I noticed that all iOS user-agent strings were being logged for the server-side portion
of an app we built with an integer appended:
> Mozilla/5.0 (iPad; CPU OS 10_0_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko)
Mobile/14A456 (5668672384)
> Mozilla/5.0 (iPad; CPU OS 10_0_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko)
Mobile/14A456 (4299221040)
> Mozilla/5.0 (iPad; CPU OS 10_0_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko)
Mobile/14A456 (4299251504)
> This seems to originate from:
> https://github.com/apache/cordova-ios/blob/master/CordovaLib/Classes/Public/CDVViewController.m#L495L496
> Is this still needed for any reason?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message