cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12071) Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
Date Tue, 01 Nov 2016 08:38:58 GMT

    [ https://issues.apache.org/jira/browse/CB-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15624789#comment-15624789
] 

ASF GitHub Bot commented on CB-12071:
-------------------------------------

Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-windows/pull/208
  
    ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/208?src=pr) is
74.64% (diff: 100%)
    > Merging [#208](https://codecov.io/gh/apache/cordova-windows/pull/208?src=pr) into
[master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change
coverage
    
    ```diff
    @@             master       #208   diff @@
    ==========================================
      Files            15         15          
      Lines          2067       2067          
      Methods         390        390          
      Messages          0          0          
      Branches        403        403          
    ==========================================
      Hits           1543       1543          
      Misses          524        524          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update [7ed3c99...369f69a](https://codecov.io/gh/apache/cordova-windows/compare/7ed3c997af55d818354f5b5c38453b7d76ec4aa7...369f69a0618658209f29027abb1c114761ce5b83?src=pr)


> Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
> -------------------------------------------------------------------
>
>                 Key: CB-12071
>                 URL: https://issues.apache.org/jira/browse/CB-12071
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugins, Windows
>    Affects Versions: 4.4.3
>         Environment: Windows Phone 8.1, Windows 8.1, Windows 10 UWP
>            Reporter: Luc Humair
>            Priority: Critical
>
> I have a plugin which needs an InProcessServerExtension in the project's package.windows.appxmanifest
like:
> {code:xml}
>     <Extensions>
>         <Extension Category="windows.activatableClass.inProcessServer">
>             <InProcessServer>
>                 <Path>Foo.dll</Path>
>                 <ActivatableClass ActivatableClassId="Foo.Class" ThreadingModel="both"
/>
>             </InProcessServer>
>         </Extension>
>     </Extensions>
> {code}
> The corresponding DLL is configured in the plugin.xml file using:
> {code:xml}
> <resource-file device-target="windows" src="src/windows/win81/$(Platform)/Foo.dll"
target="Foo.dll" versions="8.1"/>
> <resource-file device-target="phone" src="src/windows/wpa81/$(Platform)/Foo.dll" target="Foo.dll"
versions="8.1"/>
> <resource-file src="src/windows/uap/$(Platform)/Foo.dll" target="Foo.dll" versions="&gt;=10"/>
> {code}
> This configuration worked until release 4.4.2. Foo.dll was included in the projects with
property "Package Action"="Content" which includes the DLL in the package manifest.
> Release 4.4.3 introduced a patch related to issue CB-11825 that changes  the DLL's "Package
Action" to "None". Now the file is no longer included in the package manifest and the build
fails for all the platforms with the following error message:
> package.windows.appxmanifest : error APPX0703: Manifest references file 'Foo.dll' which
is not part of the payload.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message