cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12098) Update supportedInterfaceOrientations return type
Date Tue, 01 Nov 2016 22:42:59 GMT

    [ https://issues.apache.org/jira/browse/CB-12098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15626918#comment-15626918
] 

ASF GitHub Bot commented on CB-12098:
-------------------------------------

GitHub user sterlingann opened a pull request:

    https://github.com/apache/cordova-ios/pull/271

    CB-12098 - Update supportedInterfaceOrientations return type

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    ios
    ### What does this PR do?
    fixed warning pertaining to supported interface orientation return type
    
    ### What testing has been done on this change?
    ran npm test, created a test project
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sterlingann/cordova-ios CB-12098

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #271
    
----
commit 63e14a1ed4b387552a9386176b3d02b23adeaf1e
Author: Sterling <sterlingann@gmail.com>
Date:   2016-11-01T18:40:12Z

    CB-12098 - Update supportedInterfaceOrientations return type

----


> Update supportedInterfaceOrientations return type
> -------------------------------------------------
>
>                 Key: CB-12098
>                 URL: https://issues.apache.org/jira/browse/CB-12098
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 3.5.0
>            Reporter: Jesse MacFadyen
>            Assignee: sterling gerritz
>            Priority: Minor
>
> All of our uses of supportedInterfaceOrientations should return UIInterfaceOrientationMask
in iOS 9+
> {code}
> #if __IPHONE_OS_VERSION_MAX_ALLOWED < 90000  
> - (NSUInteger)supportedInterfaceOrientations  
> #else  
> - (UIInterfaceOrientationMask)supportedInterfaceOrientations
> #endif
> {code}
> The full list of references is here:
> https://github.com/apache/cordova-ios/search?utf8=%E2%9C%93&q=supportedInterfaceOrientations
> A similar fix was just implemented for [CB-11189]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message