cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-11977) Remove support for node 0.x
Date Wed, 22 Feb 2017 22:02:44 GMT

    [ https://issues.apache.org/jira/browse/CB-11977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879334#comment-15879334
] 

ASF GitHub Bot commented on CB-11977:
-------------------------------------

GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-lib/pull/520

    CB-11977 : removed support for node 0.x

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    Removed support for node 0.x. Node 4 and 6 still supported.
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-lib CB-11977

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/520.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #520
    
----
commit f5707c8562b4ecf805c7923a70448afd95f6a712
Author: Audrey So <audreyso@apache.org>
Date:   2017-02-22T21:47:01Z

    CB-11977 : removed support for node 0.x

----


> Remove support for node 0.x
> ---------------------------
>
>                 Key: CB-11977
>                 URL: https://issues.apache.org/jira/browse/CB-11977
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CLI, CordovaLib
>            Reporter: Steve Gill
>              Labels: cordova-7.0.0
>             Fix For: 7.0.0
>
>
> Don't do this until January 2017 according to node deprecation timeline. https://github.com/cordova/cordova-discuss/blob/master/proposals/NodeJsDeprecation.md
> Use engines key in package.json https://docs.npmjs.com/files/package.json#engines



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message