cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12443) Include fragments when building URLs
Date Wed, 22 Feb 2017 21:18:44 GMT

    [ https://issues.apache.org/jira/browse/CB-12443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879251#comment-15879251
] 

ASF GitHub Bot commented on CB-12443:
-------------------------------------

Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-plugins/pull/28#discussion_r102574949
  
    --- Diff: local-webserver/src/ios/CDVLocalWebServer.m ---
    @@ -52,6 +53,12 @@ - (void) pluginInitialize {
         if (startPageUrl != nil) {
             if ([[startPageUrl scheme] isEqualToString:@"http"] && [[startPageUrl
host] isEqualToString:@"localhost"]) {
                 port = [[startPageUrl port] unsignedIntegerValue];
    +            if ([startPageUrl path].length > 1) {
    +                indexPage = [[startPageUrl path] substringFromIndex:1];
    +            }
    +            if ([startPageUrl fragment].length > 1) {
    --- End diff --
    
    Similarly here. Fragments that are 1 char in length will not be considered as well.


> Include fragments when building URLs
> ------------------------------------
>
>                 Key: CB-12443
>                 URL: https://issues.apache.org/jira/browse/CB-12443
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Jordan Haven
>
> When setting the start page with a fragment in the URL, the fragment is lost.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message