[ https://issues.apache.org/jira/browse/CB-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878283#comment-15878283
]
ASF GitHub Bot commented on CB-12453:
-------------------------------------
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-android/pull/362
CB-12453: Remove unnecessary double quotes from .bat files which are the causes of crash
if project path contains spaces
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
self
### What does this PR do?
This PR fixes bug with crash if project path contains spaces
### What testing has been done on this change?
Current auto-tests don't work if project path contains spaces, this PR fixes it
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-android allow-spaces-in-project-path
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #362
----
commit 7f2f6943459c8bd806b8d6aea77e4b447260ecb8
Author: Nikita Matrosov <v-nimatr@microsoft.com>
Date: 2017-02-16T14:36:23Z
CB-12453: Remove unnecessary double quotes from .bat files which are the causes of crash
if project path contains spaces
----
> "cordova run --list" throws error when there's a space in user name
> -------------------------------------------------------------------
>
> Key: CB-12453
> URL: https://issues.apache.org/jira/browse/CB-12453
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI, Windows
> Affects Versions: 6.4.0, 6.5.0
> Environment: Windows 10 64 bit, cordova version 6.5 (not in list?) CLI
> Reporter: Yousif Touma
> Labels: cli, list-devices, windows10
>
> When trying to list available devices to run on, cordova throws an error if the user
has a space in user name
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
|