cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12626) Splashscreen crashing on Samsung devices, not rendering on others
Date Thu, 05 Oct 2017 19:09:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193463#comment-16193463
] 

ASF GitHub Bot commented on CB-12626:
-------------------------------------

Github user Lazza commented on the issue:

    https://github.com/apache/cordova-plugin-splashscreen/pull/125
  
    @infil00p When I created this pull request I only added code for Android. I have **never**
included iOS code at the time of creation of this pull request.
    
    I have no idea why now GitHub has decided to include some other unrelated code into my
pull request, nor I have time to investigate now. I am working on a client project and needed
to have another fix as well, but of course this has been applied months after the previous
pull request so it is ridiculous that it is being included here by GitHub.
    
    As a matter of fact, my pull request code was also correctly tagged (the tag is `bulletproof-fix`).
    
    As a side note, I see there was no intention at all to accept it even before this incident,
but no big deal. People who want a correct behavior on Samsung devices can find the code.


> Splashscreen crashing on Samsung devices, not rendering on others
> -----------------------------------------------------------------
>
>                 Key: CB-12626
>                 URL: https://issues.apache.org/jira/browse/CB-12626
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-android, cordova-plugin-splashscreen
>         Environment: Crashing devices:
> - Samsung Galaxy 7 Edge, Android 7.0
> - Samsung Galaxy Note 4, Android 6.0.1
> "Not showing" devices:
> - Lenovo/Zuk Z1, Android 5.1.1
> - Official Android Emulator with Nexus S simulated hardware, API 25
>            Reporter: Andrea Lazzarotto
>            Assignee: Joe Bowser
>              Labels: android, android-next
>
> We tested the plugin on a few Samsung devices and found out that the current version
of the splash screen plug-in is completely crashing the app, with an error given by {{AndroidRuntime}}
(including the PID of the app) and a warning given by {{ActivityManager}} in the log:
> {{Force finishing activity packagename/.MainActivity}}
> Moreover, we noticed that the splash screen is not showing correctly on some devices.
The Samsung crash was initially solved by commenting out this line:
> {{preferences.set("SplashDrawableId", drawableId);}}
> Basically, this means that storing the {{drawableId}} in the preferences is not reliable.
This didn't solve the display issue on other devices, which required refactoring the code
that reads the resource ID.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message