cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13303) cordova fetch should use --production flag by default
Date Tue, 03 Oct 2017 21:34:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190383#comment-16190383
] 

ASF GitHub Bot commented on CB-13303:
-------------------------------------

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-cli/pull/287#discussion_r142529980
  
    --- Diff: src/cli.js ---
    @@ -465,6 +473,14 @@ function cli (inputArgs) {
                 // User explicitly did not pass in searchpath
                 args.searchpath = conf.get('searchpath');
             }
    +        if (args.production === undefined) {
    +            // User explicitly did not pass in noprod
    +            args.production = conf.get('production');
    +        }
    +        if (args.noprod === undefined) {
    --- End diff --
    
    lets not offer `noprod` in config. Just `args.production`. We only need noprod like you
have in line 454. Used to figure out of args.production is true or false. 


> cordova fetch should use --production flag by default 
> ------------------------------------------------------
>
>                 Key: CB-13303
>                 URL: https://issues.apache.org/jira/browse/CB-13303
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: cordova-fetch
>            Reporter: Steve Gill
>            Assignee: Audrey So
>              Labels: backlog, tools-next
>
> This should speed up cordova-fetch. When installing platforms and plugins, run npm install
--production under the hood so we don't fetch dev dependencies. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message