cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock
Date Thu, 05 Oct 2017 19:18:01 GMT

    [ https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193477#comment-16193477
] 

ASF GitHub Bot commented on CB-13405:
-------------------------------------

GitHub user dnfield reopened a pull request:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/24

    CB-13405: (ios) Go to last used orientation before locking when unlocking screen on iOS

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dnfield/cordova-plugin-screen-orientation master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-screen-orientation/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 114aeef0bb79478098669594e7207357ffcc7644
Author: Dan Field <dnfield@travelers.com>
Date:   2017-10-05T18:13:26Z

    CB-13405: (ios) Screen unlock bug fix

commit b4db5e2796abf7a773b8e644f55e9457c221693a
Author: Dan Field <dnfield@travelers.com>
Date:   2017-10-05T19:16:07Z

    CB-13405: (ios) undo lock when resetting

----


> iOS screen orientation plugin fails to reset on unlock
> ------------------------------------------------------
>
>                 Key: CB-13405
>                 URL: https://issues.apache.org/jira/browse/CB-13405
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-screen-orientation
>         Environment: all iOS
>            Reporter: Dan Field
>            Assignee: Vishal Mishra
>            Priority: Minor
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device fails to rotate
until user manually rotates back and forth.  T



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message