cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13964) 'Make' command to build cordova website dont work in windows
Date Fri, 16 Mar 2018 16:24:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402126#comment-16402126
] 

ASF GitHub Bot commented on CB-13964:
-------------------------------------

dblotsky commented on a change in pull request #806: CB-13964: Fixed make clean for windows
URL: https://github.com/apache/cordova-docs/pull/806#discussion_r175142882
 
 

 ##########
 File path: Makefile
 ##########
 @@ -50,6 +50,11 @@ else
 printfile = cat $(1)
 endif
 
+ifdef WINDOWS
+RM = cmd /C del /Q /F $(subst /,\,$(1))
+RMDIR  = cmd /C rmdir /S /Q $(subst /,\,$(1))
+endif
 
 Review comment:
   You can make non-Windows versions of these, and then you won't have to use Windows-specific
logic in the `clean` target. So, add an `else` clause and just define:
   ```makefile
   else
   RM = rm -f $(1)
   RMDIR = rm -rf $(1)
   endif
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> 'Make' command to build cordova website dont work in windows
> ------------------------------------------------------------
>
>                 Key: CB-13964
>                 URL: https://issues.apache.org/jira/browse/CB-13964
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-docs
>            Reporter: Gandhirajan
>            Priority: Critical
>
> Make commands for cordova website devleopment dont work in windows OS



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message