cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13964) 'Make' command to build cordova website dont work in windows
Date Mon, 19 Mar 2018 16:57:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405117#comment-16405117
] 

ASF GitHub Bot commented on CB-13964:
-------------------------------------

janpio closed pull request #806: CB-13964: Fixed make clean for windows
URL: https://github.com/apache/cordova-docs/pull/806
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/Makefile b/Makefile
index 8d8482928..43e95a229 100644
--- a/Makefile
+++ b/Makefile
@@ -50,6 +50,14 @@ else
 printfile = cat $(1)
 endif
 
+ifdef WINDOWS
+RM = cmd /C del /Q /F $(subst /,\,$(1))
+RMDIR  = cmd /C rmdir /S /Q $(subst /,\,$(1))
+else
+RM = rm -f $(1)
+RMDIR = rm -rf $(1)
+endif
+
 # constants
 EMPTY =
 SPACE = $(EMPTY) $(EMPTY)
@@ -152,7 +160,7 @@ NEXT_DOCS_TOCS = $(addprefix $(TOC_DIR)/,$(addsuffix _$(NEXT_DOCS_VERSION_SLUG)-
 JEKYLL_CONFIGS = $(MAIN_CONFIG) $(DEFAULTS_CONFIG) $(VERSION_CONFIG)
 JEKYLL_FLAGS   =
 
-BUILD_DATA = $(DOCS_VERSION_DATA) $(DOCS_PAGE_LIST) $(TOC_FILES)
+BUILD_DATA = $(TOC_FILES) $(DOCS_VERSION_DATA) $(DOCS_PAGE_LIST)
 
 # convenience targets
 help usage default:
@@ -288,18 +296,19 @@ $(CSS_DEST_DIR)/%.css: $(CSS_SRC_DIR)/%.css
 
 # maintenance
 clean:
-	$(RM) $(VERSION_CONFIG)
-	$(RM) $(DEFAULTS_CONFIG)
-	$(RM) $(DOCS_PAGE_LIST)
-	$(RM) $(DOCS_VERSION_DATA)
-	$(RM) -r $(PROD_DIR) $(DEV_DIR)
-	$(RM) $(TOC_FILES)
-	$(RM) $(PLUGINS_APP)
-	$(RM) -r $(CSS_DEST_DIR)
-	$(RM) $(FETCHED_FILES)
+	$(call RM, $(VERSION_CONFIG))
+	$(call RM, $(DEFAULTS_CONFIG))
+	$(call RM, $(DOCS_PAGE_LIST))
+	$(call RM, $(DOCS_VERSION_DATA))
+	$(call RM, $(TOC_FILES))
+	$(call RM, $(PLUGINS_APP))
+	$(call RM, $(FETCHED_FILES))
+	-$(call RMDIR, $(CSS_DEST_DIR))
+	-$(call RMDIR, $(PROD_DIR))
+	-$(call RMDIR, $(DEV_DIR))
 
 nuke: clean
-	$(RM) -r node_modules
-	$(RM) Gemfile.lock
+	$(call RMDIR, node_modules)
+	$(call RM, Gemfile.lock)
 
-.PHONY: clean usage help default build fetch $(DEV_DOCS)
+.PHONY: clean usage help default build fetch $(DEV_DOCS)
\ No newline at end of file


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> 'Make' command to build cordova website dont work in windows
> ------------------------------------------------------------
>
>                 Key: CB-13964
>                 URL: https://issues.apache.org/jira/browse/CB-13964
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-docs
>            Reporter: Gandhirajan
>            Priority: Critical
>
> Make commands for cordova website devleopment dont work in windows OS



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message