From issues-return-93485-apmail-cordova-issues-archive=cordova.apache.org@cordova.apache.org Mon Mar 19 16:57:05 2018 Return-Path: X-Original-To: apmail-cordova-issues-archive@minotaur.apache.org Delivered-To: apmail-cordova-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CEF5118AF9 for ; Mon, 19 Mar 2018 16:57:05 +0000 (UTC) Received: (qmail 63856 invoked by uid 500); 19 Mar 2018 16:57:05 -0000 Delivered-To: apmail-cordova-issues-archive@cordova.apache.org Received: (qmail 63835 invoked by uid 500); 19 Mar 2018 16:57:05 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 63742 invoked by uid 99); 19 Mar 2018 16:57:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2018 16:57:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D4F061A09AE for ; Mon, 19 Mar 2018 16:57:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id kAVROoEtbNiA for ; Mon, 19 Mar 2018 16:57:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B1E375F5E0 for ; Mon, 19 Mar 2018 16:57:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 96C6BE0D77 for ; Mon, 19 Mar 2018 16:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BF3F3214BE for ; Mon, 19 Mar 2018 16:57:00 +0000 (UTC) Date: Mon, 19 Mar 2018 16:57:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-13964) 'Make' command to build cordova website dont work in windows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405117#comment-16405117 ] ASF GitHub Bot commented on CB-13964: ------------------------------------- janpio closed pull request #806: CB-13964: Fixed make clean for windows URL: https://github.com/apache/cordova-docs/pull/806 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/Makefile b/Makefile index 8d8482928..43e95a229 100644 --- a/Makefile +++ b/Makefile @@ -50,6 +50,14 @@ else printfile = cat $(1) endif +ifdef WINDOWS +RM = cmd /C del /Q /F $(subst /,\,$(1)) +RMDIR = cmd /C rmdir /S /Q $(subst /,\,$(1)) +else +RM = rm -f $(1) +RMDIR = rm -rf $(1) +endif + # constants EMPTY = SPACE = $(EMPTY) $(EMPTY) @@ -152,7 +160,7 @@ NEXT_DOCS_TOCS = $(addprefix $(TOC_DIR)/,$(addsuffix _$(NEXT_DOCS_VERSION_SLUG)- JEKYLL_CONFIGS = $(MAIN_CONFIG) $(DEFAULTS_CONFIG) $(VERSION_CONFIG) JEKYLL_FLAGS = -BUILD_DATA = $(DOCS_VERSION_DATA) $(DOCS_PAGE_LIST) $(TOC_FILES) +BUILD_DATA = $(TOC_FILES) $(DOCS_VERSION_DATA) $(DOCS_PAGE_LIST) # convenience targets help usage default: @@ -288,18 +296,19 @@ $(CSS_DEST_DIR)/%.css: $(CSS_SRC_DIR)/%.css # maintenance clean: - $(RM) $(VERSION_CONFIG) - $(RM) $(DEFAULTS_CONFIG) - $(RM) $(DOCS_PAGE_LIST) - $(RM) $(DOCS_VERSION_DATA) - $(RM) -r $(PROD_DIR) $(DEV_DIR) - $(RM) $(TOC_FILES) - $(RM) $(PLUGINS_APP) - $(RM) -r $(CSS_DEST_DIR) - $(RM) $(FETCHED_FILES) + $(call RM, $(VERSION_CONFIG)) + $(call RM, $(DEFAULTS_CONFIG)) + $(call RM, $(DOCS_PAGE_LIST)) + $(call RM, $(DOCS_VERSION_DATA)) + $(call RM, $(TOC_FILES)) + $(call RM, $(PLUGINS_APP)) + $(call RM, $(FETCHED_FILES)) + -$(call RMDIR, $(CSS_DEST_DIR)) + -$(call RMDIR, $(PROD_DIR)) + -$(call RMDIR, $(DEV_DIR)) nuke: clean - $(RM) -r node_modules - $(RM) Gemfile.lock + $(call RMDIR, node_modules) + $(call RM, Gemfile.lock) -.PHONY: clean usage help default build fetch $(DEV_DOCS) +.PHONY: clean usage help default build fetch $(DEV_DOCS) \ No newline at end of file ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > 'Make' command to build cordova website dont work in windows > ------------------------------------------------------------ > > Key: CB-13964 > URL: https://issues.apache.org/jira/browse/CB-13964 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs > Reporter: Gandhirajan > Priority: Critical > > Make commands for cordova website devleopment dont work in windows OS -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org