cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
Date Mon, 03 Sep 2018 13:07:01 GMT

    [ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602148#comment-16602148
] 

ASF GitHub Bot commented on CB-7179:
------------------------------------

janpio commented on a change in pull request #271: CB-7179 (iOS): Add WKWebView support for
iOS
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r214684017
 
 

 ##########
 File path: README.md
 ##########
 @@ -136,9 +136,10 @@ instance, or the system browser.
 
     iOS supports these additional options:
 
+    - __usewkwebview__: set to `yes` to use WKWebView engine for the InappBrowser. Omit or
set to `no` (default) to use UIWebView. Note: this requires that a WKWebView engine plugin
be installed in the Cordova project (e.g. [cordova-plugin-wkwebview-engine](https://github.com/apache/cordova-plugin-wkwebview-engine)
or [cordova-plugin-ionic-webview](https://github.com/ionic-team/cordova-plugin-ionic-webview)).
 
 Review comment:
   Ah, got it.
   
   2 suggestions:
   1. Change "this" in the note to "Using `usewkwebview=yes` requires ..."
   2. Change the `loaderror` callback to not refer to the specific plugin, but just mention
"... but no plugin that supplies a WKWebView engine present" (or similar)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -------------------------------------------------
>
>                 Key: CB-7179
>                 URL: https://issues.apache.org/jira/browse/CB-7179
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: cordova-plugin-inappbrowser
>         Environment: iOS 8
>            Reporter: Shazron Abdullah
>            Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message