cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CB-14194) Prepare fails when using scoped packages
Date Thu, 06 Sep 2018 18:57:00 GMT


ASF GitHub Bot commented on CB-14194:

oliversalzburg closed pull request #625: CB-14194: Don't cut off scope from package identifier

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/cordova/plugin/add.js b/src/cordova/plugin/add.js
index 8aea7f0a7..cfae7c824 100644
--- a/src/cordova/plugin/add.js
+++ b/src/cordova/plugin/add.js
@@ -129,7 +129,7 @@ function add (projectRoot, hooksRunner, opts) {
                         events.emit('verbose', 'Calling plugman.install on plugin "' + pluginInfo.dir
+ '" for platform "' + platform);
-                        return plugman.install(platform, platformRoot, path.basename(pluginInfo.dir),
pluginPath, options)
+                        return plugman.install(platform, platformRoot,, pluginPath,
                             .then(function (didPrepare) {
                                 // If platform does not returned anything we'll need
                                 // to trigger a prepare after all plugins installed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Prepare fails when using scoped packages
> ----------------------------------------
>                 Key: CB-14194
>                 URL:
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>    Affects Versions: Master
>            Reporter: Oliver Salzburg
>            Priority: Major
> When adding a plugin to a project, cordova will fail if the plugin is hosted under an
npm scope.
> The scope is cut off when searching for the installation folder on disk:
> {code}
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it to the
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml. You might
need to try adding it again. Error: Cannot find plugin.xml for plugin "cordova-plugin-push".
Please try adding it again.
> {code}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message