cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14201) Remove Gradle property in-line command arguments for gradle.properties
Date Thu, 06 Sep 2018 05:29:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605285#comment-16605285
] 

ASF GitHub Bot commented on CB-14201:
-------------------------------------

codecov-io edited a comment on issue #465: CB-14201: (android) Removes Gradle property in-line
command arguments…
URL: https://github.com/apache/cordova-android/pull/465#issuecomment-404037636
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=h1) Report
   > Merging [#465](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/cordova-android/commit/23b24491c3e2ad5721a2813ec08f80985eca5e64?src=pr&el=desc)
will **increase** coverage by `0.22%`.
   > The diff coverage is `78.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/465/graphs/tree.svg?width=650&token=q14nMf6C5a&height=150&src=pr)](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #465      +/-   ##
   ==========================================
   + Coverage   61.64%   61.87%   +0.22%     
   ==========================================
     Files          16       17       +1     
     Lines        1945     1975      +30     
     Branches      363      366       +3     
   ==========================================
   + Hits         1199     1222      +23     
   - Misses        746      753       +7
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/465/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==)
| `44.55% <100%> (-0.57%)` | :arrow_down: |
   | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/465/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz)
| `41.59% <33.33%> (-0.08%)` | :arrow_down: |
   | [...lates/cordova/lib/config/GradlePropertiesParser.js](https://codecov.io/gh/apache/cordova-android/pull/465/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jb25maWcvR3JhZGxlUHJvcGVydGllc1BhcnNlci5qcw==)
| `82.75% <82.75%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=footer).
Last update [23b2449...dacb0e5](https://codecov.io/gh/apache/cordova-android/pull/465?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove Gradle property in-line command arguments for gradle.properties
> ----------------------------------------------------------------------
>
>                 Key: CB-14201
>                 URL: https://issues.apache.org/jira/browse/CB-14201
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-android
>            Reporter: Bryan Ellis
>            Priority: Minor
>
> By passing in properties as an argument to the Gradle's command, it prevents users from
being able to override these values. 
> In one example, a user reported ([CB-14139|https://issues.apache.org/jira/browse/CB-14139])
the need to be able to set the jvmargs so builds works on 32bit Java.
> Some other values Cordova passes by default are org.gradle.daemon and android.useDeprecatedNdk.
> By removing the command line argument usage and migrating to the usage of gradle.properties,
it gives users the flexibility to override defaults if desired.  
> This ticket will also resolve [CB-14139|https://issues.apache.org/jira/browse/CB-14139]
but also remove the other argument usage.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message